Commit 68655b83 authored by Noel Alonso's avatar Noel Alonso
Browse files

Usa excepción por intento de borrado no permitido 

Se comprueba en el test
parent 12bdbbd2

src/main/java/es/redmic/commandslib/usersettings/streams/SettingsEventStreams.java

+1 −2
Original line number Diff line number Diff line
@@ -616,9 +616,8 @@ public class SettingsEventStreams extends BaseStreams { 
			return SettingsEventFactory.getEvent(evt, SettingsEventTypes.DELETE_CHECKED);

		}



		// TODO: generar nueva excepción. Si es necesario, añadir argumentos

		return SettingsEventFactory.getEvent(evt, SettingsEventTypes.CHECK_DELETE_FAILED,

				ExceptionType.ES_SELECTION_WORK.toString(), null);

				ExceptionType.DELETE_SETTINGS_NOT_ALLOWED.toString(), null);

	}



	private void processDeleteFailedStream(KStream<String, Event> events, KTable<String, Event> snapshotKTable) {

src/test/java/es/redmic/commandslib/usersettings/common/SettingsCommandHandlerBase.java

+10 −8
Original line number Diff line number Diff line
@@ -647,7 +647,7 @@ public class SettingsCommandHandlerBase extends KafkaBaseIntegrationTest { 
	}



	// Envía un evento de comprobación de que el elemento puede ser borrado y debe

	// provocar un evento CheckDeleteSettingsFailedEvent ya que no está compartido

	// provocar un evento CheckDeleteSettingsFailedEvent ya que está compartido

	@Test

	public void checkDeleteSettingsEvent_SendCheckDeleteSettingsFailedEvent_IfSettigsAreShared()

			throws InterruptedException {
@@ -664,14 +664,16 @@ public class SettingsCommandHandlerBase extends KafkaBaseIntegrationTest { 


		kafkaTemplate.send(settings_topic, event.getAggregateId(), event);



		Event confirm = (Event) blockingQueue.poll(60, TimeUnit.SECONDS);

		Event failed = (Event) blockingQueue.poll(60, TimeUnit.SECONDS);



		assertNotNull(confirm);

		assertEquals(SettingsEventTypes.CHECK_DELETE_FAILED, confirm.getType());

		assertEquals(event.getAggregateId(), confirm.getAggregateId());

		assertEquals(event.getUserId(), confirm.getUserId());

		assertEquals(event.getSessionId(), confirm.getSessionId());

		assertEquals(event.getVersion(), confirm.getVersion());

		assertNotNull(failed);

		assertEquals(SettingsEventTypes.CHECK_DELETE_FAILED, failed.getType());

		assertEquals(event.getAggregateId(), failed.getAggregateId());

		assertEquals(event.getUserId(), failed.getUserId());

		assertEquals(event.getSessionId(), failed.getSessionId());

		assertEquals(event.getVersion(), failed.getVersion());

		assertEquals(ExceptionType.SETTINGS_TO_SAVE_NOT_FOUND_EXCEPTION.toString(),

				((DeleteSettingsCheckFailedEvent) failed).getExceptionType());

	}



	// Envía un evento de confirmación de borrado y debe provocar un evento Deleted