Commit 8d60c146 authored by Chris Egerton's avatar Chris Egerton
Browse files

Change unnecessary uses of BehaviorOnNullValues.FAIL to IGNORE in tests

parent 567b1c29

src/test/java/io/confluent/connect/elasticsearch/ElasticsearchSinkTestBase.java

+1 −3
Original line number Diff line number Diff line
@@ -69,9 +69,7 @@ public class ElasticsearchSinkTestBase extends ESIntegTestCase { 
            .multiThreaded(true).build()

    );

    client = (JestHttpClient) factory.getObject();

    // Shouldn't be told to verify any records with null values; if that happens, the test should

    // automatically fail

    converter = new DataConverter(true, BehaviorOnNullValues.FAIL);

    converter = new DataConverter(true, BehaviorOnNullValues.IGNORE);

  }



  @After

src/test/java/io/confluent/connect/elasticsearch/ElasticsearchWriterTest.java

+2 −2
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ public class ElasticsearchWriterTest extends ElasticsearchSinkTestBase { 
        Collections.<String>emptySet(),

        Collections.<String>emptySet(),

        Collections.singletonMap(TOPIC, indexOverride),

        BehaviorOnNullValues.FAIL

        BehaviorOnNullValues.IGNORE

    );

    writeDataAndRefresh(writer, records);

    verifySearchResults(records, indexOverride);
@@ -423,7 +423,7 @@ public class ElasticsearchWriterTest extends ElasticsearchSinkTestBase { 
  }



  private ElasticsearchWriter initWriter(JestClient client) {

    return initWriter(client, BehaviorOnNullValues.FAIL);

    return initWriter(client, BehaviorOnNullValues.IGNORE);

  }



  private ElasticsearchWriter initWriter(JestClient client, BehaviorOnNullValues behavior) {

src/test/java/io/confluent/connect/elasticsearch/MappingTest.java

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ public class MappingTest extends ElasticsearchSinkTestBase { 
      }

    }



    DataConverter converter = new DataConverter(true, BehaviorOnNullValues.FAIL);

    DataConverter converter = new DataConverter(true, BehaviorOnNullValues.IGNORE);

    Schema.Type schemaType = schema.type();

    switch (schemaType) {

      case ARRAY: