Commit 77a08926 authored by Arjun Satish's avatar Arjun Satish
Browse files

CC-1372: Reviewer comments 



Use @Before annotation to setup props in test.

Signed-off-by: default avatarArjun Satish <arjun@confluent.io>
parent db086681

src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkTask.java

+3 −1
Original line number Diff line number Diff line
@@ -84,7 +84,9 @@ public class ElasticsearchSinkTask extends SinkTask { 
        factory.setHttpClientConfig(new HttpClientConfig.Builder(address)

            .connTimeout(connTimeout)

            .readTimeout(readTimeout)

            .multiThreaded(true).build());

            .multiThreaded(true)

            .build()

        );

        this.client = factory.getObject();

      }

src/test/java/io/confluent/connect/elasticsearch/ElasticsearchSinkConnectorConfigTest.java

+7 −7
Original line number Diff line number Diff line 
package io.confluent.connect.elasticsearch;



import org.junit.Assert;

import org.junit.Before;

import org.junit.Test;



import java.util.HashMap;
@@ -8,18 +9,18 @@ import java.util.Map; 


public class ElasticsearchSinkConnectorConfigTest {



  private Map<String, String> createProps() {

    Map<String, String> props = new HashMap<>();

    props.put(ElasticsearchSinkConnectorConfig.TYPE_NAME_CONFIG,

        ElasticsearchSinkTestBase.TYPE);

  private Map<String, String> props;



  @Before

  public void setup() {

    props = new HashMap<>();

    props.put(ElasticsearchSinkConnectorConfig.TYPE_NAME_CONFIG, ElasticsearchSinkTestBase.TYPE);

    props.put(ElasticsearchSinkConnectorConfig.CONNECTION_URL_CONFIG, "localhost");

    props.put(ElasticsearchSinkConnectorConfig.KEY_IGNORE_CONFIG, "true");

    return props;

  }



  @Test

  public void testDefaultHttpTimeoutsConfig() {

    Map<String, String> props = createProps();

    ElasticsearchSinkConnectorConfig config = new ElasticsearchSinkConnectorConfig(props);

    Assert.assertEquals(

        config.getInt(ElasticsearchSinkConnectorConfig.READ_TIMEOUT_MS_CONFIG),
@@ -33,7 +34,6 @@ public class ElasticsearchSinkConnectorConfigTest { 


  @Test

  public void testSetHttpTimeoutsConfig() {

    Map<String, String> props = createProps();

    props.put(ElasticsearchSinkConnectorConfig.READ_TIMEOUT_MS_CONFIG, "10000");

    props.put(ElasticsearchSinkConnectorConfig.CONNECTION_TIMEOUT_MS_CONFIG, "15000");

    ElasticsearchSinkConnectorConfig config = new ElasticsearchSinkConnectorConfig(props);