Commit 635b4fbe authored by Shikhar Bhushan's avatar Shikhar Bhushan
Browse files

minor: max.retry -> max.retries

parent 6eeac602

docs/configuration_options.rst

+4 −3
Original line number Diff line number Diff line 
Configuration Options

---------------------



``connection.url``

  The URL to connect to Elasticsearch.
@@ -25,7 +26,7 @@ Configuration Options 
  The number of requests to process as a batch when writing to Elasticsearch.



  * Type: int

  * Default: 10000

  * Default: 2000

  * Importance: medium



``max.in.flight.requests``
@@ -53,10 +54,10 @@ Configuration Options 
  Approximately the max number of records each task will buffer. This config controls the memory usage for each task. When the number of buffered records is larger than this value, the partitions assigned to this task will be paused.



  * Type: long

  * Default: 100000

  * Default: 20000

  * Importance: low



``max.retry``

``max.retries``

  The max allowed number of retries. Allowing retries will potentially change the ordering of records.



  * Type: int

src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkConnectorConfig.java

+5 −5
Original line number Diff line number Diff line
@@ -99,10 +99,10 @@ public class ElasticsearchSinkConnectorConfig extends AbstractConfig { 
  private static final long RETRY_BACKOFF_MS_DEFAULT = 100L;

  private static final String RETRY_BACKOFF_MS_DISPLAY = "Retry Backoff (ms)";



  public static final String MAX_RETRY_CONFIG = "max.retry";

  private static final String MAX_RETRY_DOC = "The max allowed number of retries. Allowing retries will potentially change the ordering of records.";

  private static final int MAX_RETRY_DEFAULT = 5;

  private static final String MAX_RETRY_DISPLAY = "Max Retry";

  public static final String MAX_RETRIES_CONFIG = "max.retries";

  private static final String MAX_RETRIES_DOC = "The max allowed number of retries. Allowing retries will potentially change the ordering of records.";

  private static final int MAX_RETRIES_DEFAULT = 5;

  private static final String MAX_RETRIES_DISPLAY = "Max Retries";



  public static final String SCHEMA_IGNORE_CONFIG = "schema.ignore";

  private static final String SCHEMA_IGNORE_DOC =
@@ -133,7 +133,7 @@ public class ElasticsearchSinkConnectorConfig extends AbstractConfig { 
        .define(TOPIC_SCHEMA_IGNORE_CONFIG, Type.LIST, TOPIC_SCHEMA_IGNORE_DEFAULT, Importance.LOW, TOPIC_SCHEMA_IGNORE_DOC, CONNECTOR_GROUP, 9, Width.LONG, TOPIC_SCHEMA_IGNORE_DISPLAY)

        .define(LINGER_MS_CONFIG, Type.LONG, LINGER_MS_DEFAULT, Importance.LOW, LINGER_MS_DOC, CONNECTOR_GROUP, 10, Width.SHORT, LINGER_MS_DISPLAY)

        .define(RETRY_BACKOFF_MS_CONFIG, Type.LONG, RETRY_BACKOFF_MS_DEFAULT, Importance.LOW, RETRY_BACKOFF_MS_DOC, CONNECTOR_GROUP, 11, Width.SHORT, RETRY_BACKOFF_MS_DISPLAY)

        .define(MAX_RETRY_CONFIG, Type.INT, MAX_RETRY_DEFAULT, Importance.LOW, MAX_RETRY_DOC, CONNECTOR_GROUP, 12, Width.SHORT, MAX_RETRY_DISPLAY)

        .define(MAX_RETRIES_CONFIG, Type.INT, MAX_RETRIES_DEFAULT, Importance.LOW, MAX_RETRIES_DOC, CONNECTOR_GROUP, 12, Width.SHORT, MAX_RETRIES_DISPLAY)

        .define(FLUSH_TIMEOUT_MS_CONFIG, Type.LONG, FLUSH_TIMEOUT_MS_DEFAULT, Importance.LOW, FLUSH_TIMEOUT_MS_DOC, CONNECTOR_GROUP, 13, Width.SHORT, FLUSH_TIMEOUT_MS_DISPLAY)

        .define(MAX_BUFFERED_RECORDS_CONFIG, Type.LONG, MAX_BUFFERED_RECORDS_DEFAULT, Importance.LOW, MAX_BUFFERED_RECORDS_DOC, CONNECTOR_GROUP, 14, Width.SHORT, MAX_BUFFERED_RECORDS_DISPLAY);

  }

src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkTask.java

+1 −1
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ public class ElasticsearchSinkTask extends SinkTask { 
      long lingerMs = config.getLong(ElasticsearchSinkConnectorConfig.LINGER_MS_CONFIG);

      int maxInFlightRequests = config.getInt(ElasticsearchSinkConnectorConfig.MAX_IN_FLIGHT_REQUESTS_CONFIG);

      long retryBackoffMs = config.getLong(ElasticsearchSinkConnectorConfig.RETRY_BACKOFF_MS_CONFIG);

      int maxRetry = config.getInt(ElasticsearchSinkConnectorConfig.MAX_RETRY_CONFIG);

      int maxRetry = config.getInt(ElasticsearchSinkConnectorConfig.MAX_RETRIES_CONFIG);



      if (client != null) {

        this.client = client;