Commit d45bd562 authored by Pedro Eduardo Trujillo's avatar Pedro Eduardo Trujillo
Browse files

Revisa uso de variables globales y comprobaciones

parent 1fda36a2
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ function(

		_checkDomainToAddMessage: function() {

			if (redmicConfig.getEnvVariableValue('envProduction') === 'false') {
			if ((/false/i).test(redmicConfig.getEnvVariableValue('envProduction'))) {
				this._addMessage('.appDev', this.i18n.messageAppDev);
			}
		},
+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ define([

		_onNotImplementedMethod: function(method, props) {

			if (redmicConfig.getEnvVariableValue('envDebug') === 'true') {
			if ((/true/i).test(redmicConfig.getEnvVariableValue('envDebug'))) {
				// TODO demasiado ruido y no aporta casi nada, quitar si no se echa en falta
				//this._showNotImplementedMethodWarning(method, props);
			}
+4 −1
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ define([
	, "src/component/base/_Show"
	, "src/component/layout/templateDisplayer/TemplateDisplayer"
	, "put-selector/put"
	, 'src/redmicConfig'
	, "templates/DocumentAuthFailed"
	, "templates/DocumentNotAvailable"
], function(
@@ -16,6 +17,7 @@ define([
	, _Show
	, TemplateDisplayer
	, put
	, redmicConfig
	, TemplateAuthFailed
	, TemplateNoAvailable
) {
@@ -98,7 +100,8 @@ define([

				this.lastPDF = url;

				var path = '/' + ((/true/i).test(envUseBuilt) ? 'js' : 'dep') + '/pdfjs/web/viewer.html?file=' + url;
				var useBuilt = (/true/i).test(redmicConfig.getEnvVariableValue('envUseBuilt')),
					path = '/' + (useBuilt ? 'js' : 'dep') + '/pdfjs/web/viewer.html?file=' + url;

				if (!this.roleGuestActive) {
					path += '?access_token%3D' + Credentials.get("accessToken");
+1 −1
Original line number Diff line number Diff line
@@ -452,7 +452,7 @@ define([

			this._isValidProperty = !propErrors;

			if (redmicConfig.getEnvVariableValue('envDebug') === 'true') {
			if ((/true/i).test(redmicConfig.getEnvVariableValue('envDebug'))) {
				console.warn('Wizard step validation', {
					property: this.propertyName,
					isValid: this._isValidProperty,
+4 −1
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ define([
	, "dojo/query"
	, 'leaflet/leaflet'
	, "put-selector/put"
	, 'src/redmicConfig'
	, "./_LeafletImplItfc"
	, './_LeafletWidgetsManagement'
	, "./_ListenContainers"
@@ -19,6 +20,7 @@ define([
	, query
	, L
	, put
	, redmicConfig
	, _LeafletImplItfc
	, _LeafletWidgetsManagement
	, _ListenContainers
@@ -48,7 +50,8 @@ define([

		_initialize: function() {

			L.Icon.Default.imagePath = '/' + ((/true/i).test(envUseBuilt) ? 'js' : 'dep') + '/leaflet/dist/images/';
			var useBuilt = (/true/i).test(redmicConfig.getEnvVariableValue('envUseBuilt'));
			L.Icon.Default.imagePath = '/' + (useBuilt ? 'js' : 'dep') + '/leaflet/dist/images/';

			this.mapParentNode = put("div.map");
			this.mapNode = put(this.mapParentNode, "div.map");
Loading